aleksey-kurinov commented on a change in pull request #7977:
URL: https://github.com/apache/ignite/pull/7977#discussion_r465166217
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/IgniteCacheTopologySplitAbstractTest.java
##########
@@ -217,14 +217,13 @@ protected void checkSegmented(InetSocketAddress sockAddr,
long timeout) throws S
/** {@inheritDoc} */
@Override protected void writeToSocket(
- Socket sock,
- TcpDiscoveryAbstractMessage msg,
- byte[] data,
- long timeout
+ Socket sock,
+ byte[] data,
Review comment:
fixed
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/BlockTcpDiscoverySpi.java
##########
@@ -74,8 +74,16 @@ private synchronized void apply(ClusterNode addr,
TcpDiscoveryAbstractMessage ms
clo.apply(addr, delegate);
}
- /** {@inheritDoc} */
- @Override protected void writeToSocket(
+ /**
+ * Writes message to the socket.
+ *
+ * @param sock Socket.
Review comment:
fixed. i've reviewd code obe more time and i've veririden method instead
of overloading. so doc is inherited now.
TcpDiscoveryConnectionCheckMessage is used as a stub instead of msg which
was pased via parameter according to your comment:
// Replace logic routine message with a stub to update last-sent-time to
avoid segmentation on
// connRecoveryTimeout.
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpClientDiscoverySpiFailureTimeoutSelfTest.java
##########
@@ -449,7 +449,7 @@ public void clientReconnectOnCoordinatorRouterFail(int
srvNodes) throws Exceptio
private Exception err;
/** */
- @Override protected void writeToSocket(
Review comment:
fixed. i've reviewd code obe more time and i've veririden method instead
of overloading. so doc is inherited now.
TcpDiscoveryConnectionCheckMessage is used as a stub instead of msg which
was pased via parameter according to your comment:
// Replace logic routine message with a stub to update last-sent-time to
avoid segmentation on
// connRecoveryTimeout.
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpClientDiscoverySpiSelfTest.java
##########
@@ -2578,15 +2578,23 @@ private void pauseResumeOperation(boolean isPause,
AtomicBoolean... locks) {
afterWrite.apply(msg, sock);
}
- /** {@inheritDoc} */
Review comment:
fixed. i've reviewd code obe more time and i've veririden method instead
of overloading. so doc is inherited now.
TcpDiscoveryConnectionCheckMessage is used as a stub instead of msg which
was pased via parameter according to your comment:
// Replace logic routine message with a stub to update last-sent-time to
avoid segmentation on
// connRecoveryTimeout.
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryFailedJoinTest.java
##########
@@ -200,10 +200,10 @@ private void assertStartFailed(final String name) {
*/
private static class DropTcpDiscoverySpi extends TcpDiscoverySpi {
/** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock,
TcpDiscoveryAbstractMessage msg, byte[] data,
- long timeout) throws IOException {
+ @Override protected void writeToSocket(Socket sock, byte[] data,
+ long timeout) throws
IOException {
Review comment:
fixed
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryPendingMessageDeliveryTest.java
##########
@@ -251,10 +251,10 @@ private void sendDummyCustomMessage(TcpDiscoverySpi
disco, IgniteUuid id) {
*/
private class DyingDiscoverySpi extends TcpDiscoverySpi {
/** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock,
TcpDiscoveryAbstractMessage msg, byte[] data,
- long timeout) throws IOException {
+ @Override protected void writeToSocket(Socket sock, byte[] data,
+ long timeout) throws
IOException {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
