Vladsz83 commented on a change in pull request #7977:
URL: https://github.com/apache/ignite/pull/7977#discussion_r470096717
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryCoordinatorFailureTest.java
##########
@@ -282,17 +282,17 @@ public void awaitDrop() throws InterruptedException,
IgniteCheckedException {
/** {@inheritDoc} */
@Override protected void writeToSocket(
Socket sock,
- TcpDiscoveryAbstractMessage msg,
byte[] data,
long timeout
) throws IOException {
- if (isDrop(msg)) {
- // Replace logic routine message with a stub to update
last-sent-time to avoid segmentation on
- // connRecoveryTimeout.
- msg = new TcpDiscoveryConnectionCheckMessage(locNode);
- }
- super.writeToSocket(sock, msg, data, timeout);
+ // Replace logic routine message with a stub to update
last-sent-time to avoid segmentation on
Review comment:
@aleksey-kurinov I think we don't need this failure emulation in
`FailingDiscoverySpi` any more. It passes no message. This is idea of the
ticket. The `msg` is always null. This `writeToSocket` works with `data`. The
test goes well without emulation a failure here. Can you check it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
