Vladsz83 commented on a change in pull request #8142:
URL: https://github.com/apache/ignite/pull/8142#discussion_r469208452



##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -81,31 +103,68 @@ def teardown(self):
     @cluster(num_nodes=NUM_NODES)
     @parametrize(version=str(DEV_BRANCH))
     @parametrize(version=str(LATEST_2_7))
-    def test_tcp(self, version):
+    def test_tcp_not_coordinator_single(self, version):
+        """
+        Test single-node-failure scenario (not the coordinator) with 
TcpDiscoverySpi.
+        """
+        return self.__simulate_nodes_failure(version, self.__properties(), 1)

Review comment:
       > @matrix
   
   We won't distinguish easily which test failed because, for example, 0 nodes 
to kill means to kill coordinator in internal routines. This reduces parameters 
count. Now we clearly  see it by test name. There is a lot of parametrization 
to me. We got 6 test functions. They look not so many. Makes sense?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to