Vladsz83 commented on a change in pull request #8142:
URL: https://github.com/apache/ignite/pull/8142#discussion_r469225365
##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -81,31 +103,68 @@ def teardown(self):
@cluster(num_nodes=NUM_NODES)
@parametrize(version=str(DEV_BRANCH))
@parametrize(version=str(LATEST_2_7))
- def test_tcp(self, version):
+ def test_tcp_not_coordinator_single(self, version):
+ """
+ Test single-node-failure scenario (not the coordinator) with
TcpDiscoverySpi.
+ """
+ return self.__simulate_nodes_failure(version, self.__properties(), 1)
Review comment:
Yes, counter-intuitive. But you don't see it now. Now we have intuitive
test names. It will become counter-inuitive with @matrix. This parametrization
requires extra test organization. This PR do not include case for failing
coordinator with some othe node. This could be done with some small changes and
parameter. But looks like anohter ticket and PR to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
