anton-vinogradov commented on a change in pull request #8142:
URL: https://github.com/apache/ignite/pull/8142#discussion_r469220569
##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -81,31 +103,68 @@ def teardown(self):
@cluster(num_nodes=NUM_NODES)
@parametrize(version=str(DEV_BRANCH))
@parametrize(version=str(LATEST_2_7))
- def test_tcp(self, version):
+ def test_tcp_not_coordinator_single(self, version):
+ """
+ Test single-node-failure scenario (not the coordinator) with
TcpDiscoverySpi.
+ """
+ return self.__simulate_nodes_failure(version, self.__properties(), 1)
Review comment:
I see code duplication and we have to reduce it if possible.
@matrix made for this.
0 to stop coordinator looks counter-intuitive to me, what about the case
when we have kill coordinator and some node?
How to kill node after coordinator in one case and before at another?
matrix with a list of nodes to kill will be more clear? eg. [0, 3, 7], [5,
0, 2], [0, 5, 2].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
