Vladsz83 commented on a change in pull request #7977:
URL: https://github.com/apache/ignite/pull/7977#discussion_r470573184
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpClientDiscoverySpiSelfTest.java
##########
@@ -2578,15 +2578,23 @@ private void pauseResumeOperation(boolean isPause,
AtomicBoolean... locks) {
afterWrite.apply(msg, sock);
}
- /** {@inheritDoc} */
Review comment:
I see particular case as understanding what failed test does and how to
fix it. Or, at least, how to locally return broken logic. Skipping certain
messages in this case, not skipping others. I would start with logging messages
in failed test on master-branch. Which of them are skipped and what is the
corresponding raw data (byte[]). We might slightly re-write skipping messages
basing on the raw data, not on the message unused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
