Vladsz83 commented on a change in pull request #7977:
URL: https://github.com/apache/ignite/pull/7977#discussion_r470133039
##########
File path:
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpClientDiscoverySpiSelfTest.java
##########
@@ -2579,14 +2581,16 @@ private void pauseResumeOperation(boolean isPause,
AtomicBoolean... locks) {
}
/** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock,
TcpDiscoveryAbstractMessage msg, byte[] msgBytes,
Review comment:
@aleksey-kurinov , I think we dont need this message-drop emulation at
all (`TestTcpDiscoverySpi.oid writeToSocket(Socket sock, byte[] msgBytes, long
timeout)`) because `TcpDiscoverySpi` doesn't send the message. It uses raw
bites instead. This is the idea of the ticket. But several tests can fail after
this change. It might become a challenge to understand what and why the tests
simulate and how to fix them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
