dmagda commented on a change in pull request #8430:
URL: https://github.com/apache/ignite/pull/8430#discussion_r520867019
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -56,6 +56,7 @@ You can find the complete list of properties in the
javadoc:org.apache.ignite.sp
| `localPort` | The port that the node binds to. If set to a non-default
value, other cluster nodes must know this port to be able to discover the node.
| `47500`
| `localPortRange`| If the `localPort` is busy, the node attempts to bind to
the next port (incremented by 1) and continues this process until it finds a
free port. The `localPortRange` property defines the number of ports the node
will try (starting from `localPort`).
| `100`
+| `soLinger`| Setting linger-on-close can help with socket deadlocks of SSL
issues like JDK-8219658. But costs longer detection of node failure. | `0`
Review comment:
The linger setting is a TCP parameter that changes how the protocol
behaves. Even if the initial motivation for adding it to the discovery SPI was
to address the SSL issue, the setting still needs to be explained generically
because it helps you to control the TCP behavior for all sorts of needs.
The workarounds are usually handled via system properties in Ignite. As long
as you've already added a new API method to the public interface it needs to be
explained generically. Otherwise, you can remove the linger setting from the
API and create a system property for the workaround instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
