dmagda commented on a change in pull request #8430:
URL: https://github.com/apache/ignite/pull/8430#discussion_r521359420
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -56,6 +56,7 @@ You can find the complete list of properties in the
javadoc:org.apache.ignite.sp
| `localPort` | The port that the node binds to. If set to a non-default
value, other cluster nodes must know this port to be able to discover the node.
| `47500`
| `localPortRange`| If the `localPort` is busy, the node attempts to bind to
the next port (incremented by 1) and continues this process until it finds a
free port. The `localPortRange` property defines the number of ports the node
will try (starting from `localPort`).
| `100`
+| `soLinger`| Setting linger-on-close can help with socket deadlocks of SSL
issues like JDK-8219658. But costs longer detection of node failure. | `0`
Review comment:
The value of the parameter [is passed into the Socket via its Java
API](https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java#L1687),
thus the description on this page needs to sound generic like in Java. Our
[JavaDoc follows this
guideline](https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.html#setSoLinger-int-)
and doesn't mention any workarounds for specific use cases.
We can put everything together this way mentioning the SSL issue as a reason
why this parameter set to 0 for Ignite discovery sockets:
_Specifies a linger-on-close timeout. This option disables/enables immediate
return from a close() of a TCP Socket. The option defaults to `0` for Ignite
TcpDiscovery sockets to avoid [potential deadlocks with SSL
connections](https://bugs.openjdk.java.net/browse/JDK-8219658)._
Please take this all into consideration and send another pull-request. We've
already beat this to death. The initial pull-request was merged skipping a
review of technical documentation committers and maintainers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
