Vladsz83 commented on a change in pull request #8430:
URL: https://github.com/apache/ignite/pull/8430#discussion_r521307187
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -56,6 +56,7 @@ You can find the complete list of properties in the
javadoc:org.apache.ignite.sp
| `localPort` | The port that the node binds to. If set to a non-default
value, other cluster nodes must know this port to be able to discover the node.
| `47500`
| `localPortRange`| If the `localPort` is busy, the node attempts to bind to
the next port (incremented by 1) and continues this process until it finds a
free port. The `localPortRange` property defines the number of ports the node
will try (starting from `localPort`).
| `100`
+| `soLinger`| Setting linger-on-close can help with socket deadlocks of SSL
issues like JDK-8219658. But costs longer detection of node failure. | `0`
Review comment:
> The linger setting is a TCP parameter that changes how the protocol
behaves.
linger only sets socket behavior on socket closing with rest of the data in
TCP buffers. But this doesn’t affect behavior of Discovery because it has own
message acknowledgement. The exception is the delay of Discovery. That is why I
think duplicating of Java API documentation is useless for Ignite user. This
parameter doesn’t change general logic and gives no benefits to user.
> The workarounds are usually handled via system properties in Ignite. As
long as you've already added a new API method to the public interface .
I haven't. This API had been added in 2.8 as hotfix of raised SSL issue. But
hadn't been documented. We just changed its default value to disabled like
before 2.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
