alex-plekhanov commented on a change in pull request #9009:
URL: https://github.com/apache/ignite/pull/9009#discussion_r616169693
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/RowHandler.java
##########
@@ -40,6 +40,9 @@
/** */
int columnCount(Row row);
+ /** */
+ Object[] getColumns(Row row);
Review comment:
It's not only a shortcut but there is also a lot of overhead when we
copy each field of row one by one. And GroupKey class still needs to be changed
(at least `fieldsCount` method required). I think the current change doesn't
break any abstraction but produces less garbage and works faster, but I can
rewrite it to use one-by-one fields copy methods if you are not agreed. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
