korlov42 commented on a change in pull request #9009:
URL: https://github.com/apache/ignite/pull/9009#discussion_r616369327
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/RowHandler.java
##########
@@ -40,6 +40,9 @@
/** */
int columnCount(Row row);
+ /** */
+ Object[] getColumns(Row row);
Review comment:
Please don't be fooled by the fact we have only one row representation
-- array of object. You should treat a row as an abstract row. I don't like the
idea to extend the interface that way because this change is too implementation
specific (in terms of reducing garbage).
> And GroupKey class still needs to be changed
I'm OK with this. Moreover I would rather generify a GroupKey. It should be
a wrapper for the Row, and there is nothing wrong to return underlying row. But
perhaps it would be better to do under separate ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
