sanpwc commented on a change in pull request #103:
URL: https://github.com/apache/ignite-3/pull/103#discussion_r620214023
##########
File path:
modules/api/src/main/java/org/apache/ignite/configuration/schemas/network/NetworkConfigurationSchema.java
##########
@@ -23,18 +23,20 @@
import org.apache.ignite.configuration.annotation.Value;
import org.apache.ignite.configuration.storage.ConfigurationType;
-/**
- * Configuration schema for network endpoint subtree.
- */
@ConfigurationRoot(rootName = "network", type = ConfigurationType.LOCAL)
public class NetworkConfigurationSchema {
- /** */
+ /** Uniq local node name. */
+ @Value(hasDefault = true)
+ public String name = "";
+
+ /**
+ *
+ */
@Min(1024)
@Max(0xFFFF)
@Value(hasDefault = true)
- public final int port = 3040;
+ public int port = 47500;
Review comment:
Why it's not final, are you going to change it in runtime? If true how
are you going to handle such changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
