sanpwc commented on a change in pull request #103:
URL: https://github.com/apache/ignite-3/pull/103#discussion_r620218517
##########
File path:
modules/api/src/main/java/org/apache/ignite/configuration/schemas/table/TableConfigurationSchema.java
##########
@@ -15,23 +15,21 @@
* limitations under the License.
*/
-package org.apache.ignite.configuration.extended;
+package org.apache.ignite.configuration.schemas.table;
import org.apache.ignite.configuration.annotation.Config;
import org.apache.ignite.configuration.annotation.Value;
+import org.apache.ignite.configuration.validation.Immutable;
-/** */
@Config
-public class DataStorageConfigurationSchema {
- /** */
+public class TableConfigurationSchema {
@Value
- public int pageSize;
+ @Immutable
+ public String name;
- /** */
@Value
- public String storagePath;
+ public int partitions;
- /** */
@Value
- public String walPath;
+ public int replicas;
Review comment:
Should we have validation annotations and default value here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
