sanpwc commented on a change in pull request #103:
URL: https://github.com/apache/ignite-3/pull/103#discussion_r620243674
##########
File path:
modules/runner/src/main/java/org/apache/ignite/internal/app/IgnitionImpl.java
##########
@@ -108,10 +115,21 @@ else if (jsonStrBootstrapCfg != null)
var serializationRegistry = new MessageSerializationRegistry();
+ String localNodeName = netConfigurationView.name();
+
+ if (StringUtil.isNullOrEmpty(localNodeName)) {
+ localNodeName = "Node: " + netConfigurationView.port();
Review comment:
Should we use default value provided by configuration schema instead?
If true we won't call
`locConfigurationMgr.configurationRegistry().getConfiguration(NetworkConfiguration.KEY).change()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
