SammyVimes commented on a change in pull request #135: URL: https://github.com/apache/ignite-3/pull/135#discussion_r637373844
########## File path: modules/network/src/main/java/org/apache/ignite/network/internal/netty/HandshakeHandler.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.network.internal.netty; + +import io.netty.channel.ChannelDuplexHandler; +import io.netty.channel.ChannelHandlerContext; +import org.apache.ignite.network.internal.handshake.HandshakeAction; +import org.apache.ignite.network.internal.handshake.HandshakeManager; +import org.apache.ignite.network.message.NetworkMessage; + +/** + * Netty handler of the handshake operation. + */ +public class HandshakeHandler extends ChannelDuplexHandler { Review comment: Sure, this should be an InboundHandler. In the beginning I was thinking that this handler will be more like a `RecoveryProtocolHandler` so it would not only handle inbound messages but also outbound (incrementing counters and waiting for ACKs). But now I think that this handler will not be just removed but replaced by recovery protocol handler after the hadnshake, hence changing it to InboundHandler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
