SammyVimes commented on a change in pull request #135: URL: https://github.com/apache/ignite-3/pull/135#discussion_r637374044
########## File path: modules/network/src/main/java/org/apache/ignite/network/internal/handshake/HandshakeManager.java ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.network.internal.handshake; + +import io.netty.channel.Channel; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.network.internal.netty.HandshakeHandler; +import org.apache.ignite.network.internal.netty.NettySender; +import org.apache.ignite.network.message.NetworkMessage; + +/** + * Handshake operation manager. + */ +public interface HandshakeManager { + /** + * Initialize handshake manager with the channel. + * + * @param channel Channel. + */ + void init(Channel channel); + + /** + * Handle an event of the connection opening. + * + * @param channel Channel. + * @return Action to perform by {@link HandshakeHandler}. + */ + HandshakeAction onConnectionOpen(Channel channel); Review comment: In the future, I would like this method to check if there is an existing "handshaken" channel and this channel could be closed in favor of the existing one. I guess it won't hurt for now to always be a no-op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
