SammyVimes commented on a change in pull request #135:
URL: https://github.com/apache/ignite-3/pull/135#discussion_r637374879
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/internal/netty/NettyClient.java
##########
@@ -45,10 +51,16 @@
@Nullable
private volatile CompletableFuture<NettySender> clientFuture = null;
+ private CompletableFuture<Void> channelFuture = new CompletableFuture<>();
Review comment:
1. Basically, we had one future for client, `clientFuture`. It resolves
not when the channel is open but when the handshake operation is complete. In
case if we are stopping a client mid-handshake there is no way to close the
channel immediately, that's why I added a future for "channel is open" event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
