korlov42 commented on a change in pull request #201:
URL: https://github.com/apache/ignite-3/pull/201#discussion_r672156584
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/mapping/ColumnMapperBuilder.java
##########
@@ -17,17 +17,31 @@
package org.apache.ignite.internal.schema.mapping;
+import org.apache.ignite.internal.schema.Column;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
/**
* Column mapper builder interface.
*/
public interface ColumnMapperBuilder {
/**
- * Add column mapping.
+ * Add new column.
+ *
+ * @param col Column descriptor.
+ * @return {@code this} for chaining.
+ */
+ public ColumnMapperBuilder add(@NotNull Column col);
+
+ /**
+ * Remap column.
*
* @param from Source column index.
* @param to Target column index.
+ * @param col Target column descriptor.
Review comment:
let's describe when null is allowed for `col`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
