korlov42 commented on a change in pull request #201:
URL: https://github.com/apache/ignite-3/pull/201#discussion_r672162677
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/mapping/ColumnMapperImpl.java
##########
@@ -17,34 +17,56 @@
package org.apache.ignite.internal.schema.mapping;
+import org.apache.ignite.internal.schema.Column;
+import org.apache.ignite.internal.schema.SchemaDescriptor;
+import org.jetbrains.annotations.NotNull;
+
/**
* Column mapper implementation.
*/
class ColumnMapperImpl implements ColumnMapper, ColumnMapperBuilder {
Review comment:
I would prefer either split this onto two different classes or merge
ColumnMapper and ColumnMapperBuilder interfaces. The builder pattern is used
usually to create an object, not to change its state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
