AMashenkov commented on a change in pull request #201:
URL: https://github.com/apache/ignite-3/pull/201#discussion_r672185101
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/SchemaManager.java
##########
@@ -283,9 +285,9 @@ private ColumnMapper columnMapper(
continue;
if (mapper == null)
- mapper = ColumnMapping.mapperBuilder(newDesc.length());
+ mapper = ColumnMapping.mapperBuilder(newDesc);
- mapper.add(newCol.schemaIndex(), oldCol.schemaIndex());
+ mapper.add(newCol.schemaIndex(), oldCol.schemaIndex(), null);
Review comment:
Actually, the column will be ignored on merging. I wasn't able a test to
get NPE here.
Maybe we should extend tests with more complex cases involving cleanup an
old schema version.
I think you are right, the arg mustn't be 'null'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
