ivandasch commented on a change in pull request #9754:
URL: https://github.com/apache/ignite/pull/9754#discussion_r803384865
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -76,30 +76,50 @@ class IgniteSpec(metaclass=ABCMeta):
This class is a basic Spec
"""
- def __init__(self, service, jvm_opts, full_jvm_opts):
+ def __init__(self, service, jvm_opts=None, full_jvm_opts=None):
+ """
+ Only one of the jvm_opts or full_jvm_opts may be passed.
+
+ :param service: Service
+ :param jvm_opts: If passed will be added or overwrite the default ones.
+ :param full_jvm_opts: If passed will be used 'as is'. None of the
default ones will be applied.
+ """
+
+ assert (jvm_opts and not full_jvm_opts) or \
+ (not jvm_opts and full_jvm_opts) or \
+ (not jvm_opts and not full_jvm_opts)
+
self.service = service
+ self.external_jvm_opts = jvm_opts
+ self.external_full_jvm_opts = full_jvm_opts
- if full_jvm_opts:
- self.jvm_opts = full_jvm_opts
+ def get_default_jvm_opts(self):
Review comment:
May be this method should be underscored (hidden)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
