ivandasch commented on a change in pull request #9754:
URL: https://github.com/apache/ignite/pull/9754#discussion_r803450077
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -76,30 +76,50 @@ class IgniteSpec(metaclass=ABCMeta):
This class is a basic Spec
"""
- def __init__(self, service, jvm_opts, full_jvm_opts):
+ def __init__(self, service, jvm_opts=None, full_jvm_opts=None):
Review comment:
Only one dict and flag is enough. Two dicts introduces overcomplicated
logic and lead to not very good readability and maintainability of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
