ivandasch commented on a change in pull request #9754:
URL: https://github.com/apache/ignite/pull/9754#discussion_r803448743



##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -205,17 +225,49 @@ def prepare_shared_files(self, local_dir):
         self._runcmd(f"chmod a+x {local_dir}/*.sh")
         self._runcmd(f"{local_dir}/mkcerts.sh")
 
+    def final_jvm_opts(self):

Review comment:
       All these params and functions should be eliminated at all. Very hard to 
read and understand the code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to