nizhikov commented on a change in pull request #99:
URL: https://github.com/apache/ignite-extensions/pull/99#discussion_r812661381
##########
File path:
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/IgniteToKafkaCdcStreamer.java
##########
@@ -213,6 +196,18 @@ public IgniteToKafkaCdcStreamer(
/** {@inheritDoc} */
@Override public void start(MetricRegistry mreg) {
+ A.notNull(kafkaProps, "Kafka properties");
+ A.notNull(topic, "Kafka topic");
+
+ kafkaProps.setProperty(KEY_SERIALIZER_CLASS_CONFIG,
IntegerSerializer.class.getName());
+ kafkaProps.setProperty(VALUE_SERIALIZER_CLASS_CONFIG,
ByteArraySerializer.class.getName());
+
+ cachesIds = cacheNames == null
Review comment:
We should add check `A.notEmpty(cacheNames)` to ensure caches are set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
