nizhikov commented on a change in pull request #99:
URL: https://github.com/apache/ignite-extensions/pull/99#discussion_r816122315
##########
File path:
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/IgniteToKafkaCdcStreamer.java
##########
@@ -84,22 +91,28 @@
private KafkaProducer<Integer, byte[]> producer;
/** Handle only primary entry flag. */
- private final boolean onlyPrimary;
+ private boolean onlyPrimary = DFLT_IS_ONLY_PRIMARY;
/** Topic name. */
- private final String topic;
+ private String topic;
/** Kafka topic partitions count. */
- private final int kafkaParts;
+ private int kafkaParts = DFLT_PARTS;
Review comment:
Let's get rid of this default.
Looks like partitions count value should be provided explicitly always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
