nizhikov commented on a change in pull request #99:
URL: https://github.com/apache/ignite-extensions/pull/99#discussion_r816130759
##########
File path:
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteCdcStreamerConfiguration.java
##########
@@ -20,35 +20,41 @@
import java.util.Collection;
import java.util.Map;
import org.apache.ignite.internal.processors.cache.IgniteInternalCache;
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.lang.IgniteExperimental;
/**
* Configuration of {@link KafkaToIgniteCdcStreamer} application.
*
* @see KafkaToIgniteCdcStreamer
* @see KafkaToIgniteLoader
*/
+@IgniteExperimental
public class KafkaToIgniteCdcStreamerConfiguration {
+ /** Default maximum time to complete Kafka related requests, in
milliseconds. */
+ public static final int DFLT_KAFKA_REQ_TIMEOUT = 3_000;
+
/** Default {@link #kafkaPartsTo} value. */
public static final int DFLT_PARTS = 16;
- /** Default {@link #topic} value. */
- public static final String DFLT_TOPIC = "ignite";
-
/** Default {@link #maxBatchSize} value. */
public static final int DFLT_MAX_BATCH_SIZE = 1024;
/** {@link KafkaToIgniteCdcStreamerApplier} thread count. */
private int threadCnt = DFLT_PARTS;
/** Topic name. */
- private String topic = DFLT_TOPIC;
+ private String topic;
/** Kafka partitions lower bound (inclusive). */
private int kafkaPartsFrom = 0;
/** Kafka partitions higher bound (exclusive). */
private int kafkaPartsTo = DFLT_PARTS;
+ /** The maximum time to complete Kafka related requests, in milliseconds.
*/
+ private int kafkaReqTimeout = DFLT_KAFKA_REQ_TIMEOUT;
Review comment:
Why `int`? Looks like `Duration.ofMillis` take `long` as a parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
