sashapolo commented on code in PR #795:
URL: https://github.com/apache/ignite-3/pull/795#discussion_r878859392
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -401,7 +401,7 @@ public CompletableFuture<Ignite> start(@Language("HOCON")
@Nullable String cfg)
return cmgMgr.joinFuture()
// using the default executor to avoid blocking the CMG
Manager threads
- .thenAcceptAsync(v -> {
+ .thenRunAsync(() -> {
Review Comment:
I agree, but this is the only operation in this class, that requires a pool.
Do we really want to bother with creating, storing and closing an executor just
for this purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
