sashapolo commented on code in PR #795:
URL: https://github.com/apache/ignite-3/pull/795#discussion_r878859177
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java:
##########
@@ -73,11 +97,16 @@ public CompletableFuture<Void>
initCluster(Collection<String> metaStorageNodeNam
CmgInitMessage initMessage = msgFactory.cmgInitMessage()
.metaStorageNodes(metaStorageNodeNames)
.cmgNodes(cmgNodeNames)
+ .clusterName(clusterName)
.build();
return invokeMessage(cmgNodes, initMessage)
Review Comment:
> I'd add INFO logging for successful init invocation including init params
both original and resolved.
Done
> All in all, in order not to miss elements of node join logging flow
including happy path ones, could you please share the set of such entry points?
I believe that we've might miss some.
Can you elaborate please? Do you mean writing a README about the possible
flows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
