rpuch commented on code in PR #814: URL: https://github.com/apache/ignite-3/pull/814#discussion_r879579315
########## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/datapage/DataPageReader.java: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.pagememory.datapage; + +import static org.apache.ignite.internal.pagememory.util.PageIdUtils.itemId; +import static org.apache.ignite.internal.pagememory.util.PageIdUtils.pageId; +import static org.apache.ignite.internal.util.GridUnsafe.NATIVE_BYTE_ORDER; +import static org.apache.ignite.internal.util.GridUnsafe.wrapPointer; + +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.nio.ByteBuffer; +import org.apache.ignite.internal.pagememory.PageMemory; +import org.apache.ignite.internal.pagememory.io.AbstractDataPageIo; +import org.apache.ignite.internal.pagememory.io.DataPagePayload; +import org.apache.ignite.internal.pagememory.metric.IoStatisticsHolder; +import org.apache.ignite.lang.IgniteInternalCheckedException; +import org.jetbrains.annotations.Nullable; + +/** + * Contains logic for reading values from page memory data pages (this includes handling multy-page values). + */ +public abstract class DataPageReader<T> { Review Comment: I added `DataPageReader#traversal()` operation which allows to avoid code duplication when using different traversals. (The traversals themselves are stateful, but it's possible to cache their instances in thread locals, which I did). Using this new abstraction, I optimized search for version by a timestamp and added ability to only load version value when needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
