rpuch commented on code in PR #814:
URL: https://github.com/apache/ignite-3/pull/814#discussion_r881617910
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/RowVersion.java:
##########
@@ -38,10 +41,24 @@ public class RowVersion extends StorableBase {
*/
public static final long NULL_LINK = 0;
+ private static final int TIMESTAMP_STORE_SIZE_BYTES = 2 * Long.BYTES;
+ private static final int NEXT_LINK_STORE_SIZE_BYTES =
PartitionlessLinks.PARTITIONLESS_LINK_SIZE_BYTES;
+ private static final int VALUE_SIZE_STORE_SIZE_BYTES = Integer.BYTES;
+
+ public static final int TIMESTAMP_OFFSET = 0;
+ public static final int NEXT_LINK_OFFSET = TIMESTAMP_STORE_SIZE_BYTES;
+ public static final int VALUE_SIZE_OFFSET = NEXT_LINK_OFFSET +
NEXT_LINK_STORE_SIZE_BYTES;
+ public static final int VALUE_OFFSET = VALUE_SIZE_OFFSET +
VALUE_SIZE_STORE_SIZE_BYTES;
+
+ private final int partitionId;
+ private long link;
+
@Nullable
private final Timestamp timestamp;
private final long nextLink;
private final int valueSize;
+ @IgniteToStringExclude
Review Comment:
Yes, I do use blank lines when appropriate. Here, the 4 fields form a group,
that's why there are no blank lines between them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
