rpuch commented on code in PR #814:
URL: https://github.com/apache/ignite-3/pull/814#discussion_r881601938
##########
modules/storage-api/src/test/java/org/apache/ignite/internal/storage/AbstractMvPartitionStorageTest.java:
##########
@@ -291,8 +292,12 @@ void
readOfUncommittedRowWithCorrespondingTransactionIdReturnsTheRow() {
BinaryRow foundRow = storage.read(rowId, txId);
- assertThat(foundRow, is(notNullValue()));
- assertThat(foundRow.bytes(), is(equalTo(binaryRow.bytes())));
+ assertRowMatches(foundRow, binaryRow);
+ }
+
+ private void assertRowMatches(@Nullable BinaryRow rowUnderQuestion,
BinaryRow expectedRow) {
Review Comment:
'Usually' for `assertEquals()`. But for `assertMatches()` it's the other way
around: first, it's the value you check with a matcher, then, the matcher,
(that could be `is(expectedValue)`). The method name contains `Matches` as a
hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
