[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #892: IGNITE-17149 Separation of the PageMemoryStorageEngineConfigurationSchema into in-memory and persistent

[GitBox]

tkalkirill commented on code in PR #892:
URL: https://github.com/apache/ignite-3/pull/892#discussion_r905760558


##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryDataRegion.java:
##########
@@ -17,24 +17,24 @@
 
 package org.apache.ignite.internal.storage.pagememory;
 
-import java.util.Objects;
 import org.apache.ignite.internal.manager.IgniteComponent;
+import org.apache.ignite.internal.pagememory.DataRegion;
 import org.apache.ignite.internal.pagememory.PageMemory;
-import org.apache.ignite.internal.pagememory.PageMemoryDataRegion;
-import 
org.apache.ignite.internal.pagememory.configuration.schema.PageMemoryDataRegionConfiguration;
+import 
org.apache.ignite.internal.pagememory.configuration.schema.BasePageMemoryDataRegionConfiguration;
 import org.apache.ignite.internal.pagememory.io.PageIoRegistry;
+import org.apache.ignite.internal.storage.StorageException;
 
 /**
  * Abstract data region for {@link PageMemoryStorageEngine}. Based on a {@link 
PageMemory}.
  */
-abstract class AbstractPageMemoryDataRegion implements PageMemoryDataRegion, 
IgniteComponent {
-    protected final PageMemoryDataRegionConfiguration cfg;
+abstract class AbstractPageMemoryDataRegion<T extends PageMemory> implements 
DataRegion<T>, IgniteComponent {

Review Comment:
   I don't understand why it's bad?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org