tkalkirill commented on code in PR #892:
URL: https://github.com/apache/ignite-3/pull/892#discussion_r905897419
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/configuration/schema/VolatilePageMemoryDataRegionConfigurationSchema.java:
##########
@@ -43,56 +43,30 @@ public class PageMemoryDataRegionConfigurationSchema {
/** Random-2-LRU algorithm: scan-resistant version of Random-LRU. */
public static final String RANDOM_2_LRU_EVICTION_MODE = "RANDOM_2_LRU";
- /** Random-LRU algorithm. */
- public static final String RANDOM_LRU_REPLACEMENT_MODE = "RANDOM_LRU";
-
- /** Segmented-LRU algorithm. */
- public static final String SEGMENTED_LRU_REPLACEMENT_MODE =
"SEGMENTED_LRU";
-
- /** CLOCK algorithm. */
- public static final String CLOCK_REPLACEMENT_MODE = "CLOCK";
-
- /** Name of the data region. */
- @InjectedName
- public String name;
-
- @Value(hasDefault = true)
- public boolean persistent = false;
-
+ /** Initial memory region size in bytes, when the used memory size exceeds
this value, new chunks of memory will be allocated. */
@Value(hasDefault = true)
public long initSize = DFLT_DATA_REGION_INITIAL_SIZE;
+ /** Maximum memory region size in bytes. */
@Value(hasDefault = true)
public long maxSize = DFLT_DATA_REGION_MAX_SIZE;
- @ConfigValue
- public MemoryAllocatorConfigurationSchema memoryAllocator;
-
+ /** Memory pages eviction mode. */
@OneOf({DISABLED_EVICTION_MODE, RANDOM_LRU_EVICTION_MODE,
RANDOM_2_LRU_EVICTION_MODE})
@Value(hasDefault = true)
public String evictionMode = DISABLED_EVICTION_MODE;
- @OneOf({RANDOM_LRU_REPLACEMENT_MODE, SEGMENTED_LRU_REPLACEMENT_MODE,
CLOCK_REPLACEMENT_MODE})
- @Value(hasDefault = true)
- public String replacementMode = CLOCK_REPLACEMENT_MODE;
-
+ /**
+ * Threshold for memory pages eviction initiation. For instance, if the
threshold is 0.9 it means that the page memory will start the
+ * eviction only after 90% of the data region is occupied.
+ */
@Value(hasDefault = true)
public double evictionThreshold = 0.9;
- @Value(hasDefault = true)
- public int emptyPagesPoolSize = 100;
-
- @Value(hasDefault = true)
- public long checkpointPageBufSize = 0;
-
- @Value(hasDefault = true)
- public boolean lazyMemoryAllocation = true;
-
/**
- * Write to the page store without holding the segment lock (with a delay).
- *
- * <p>Because other thread may require exactly the same page to be loaded
from page store, reads are protected by locking.
+ * Number of empty pages to be present in reuse lists. This parameter
ensures that Ignite will be able to successfully evict old data
Review Comment:
It will need to be changed so that **IgniteOutOfMemoryError** does not
happen on the next start of the node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
