sashapolo commented on code in PR #892:
URL: https://github.com/apache/ignite-3/pull/892#discussion_r905893858
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryDataRegion.java:
##########
@@ -17,24 +17,24 @@
package org.apache.ignite.internal.storage.pagememory;
-import java.util.Objects;
import org.apache.ignite.internal.manager.IgniteComponent;
+import org.apache.ignite.internal.pagememory.DataRegion;
import org.apache.ignite.internal.pagememory.PageMemory;
-import org.apache.ignite.internal.pagememory.PageMemoryDataRegion;
-import
org.apache.ignite.internal.pagememory.configuration.schema.PageMemoryDataRegionConfiguration;
+import
org.apache.ignite.internal.pagememory.configuration.schema.BasePageMemoryDataRegionConfiguration;
import org.apache.ignite.internal.pagememory.io.PageIoRegistry;
+import org.apache.ignite.internal.storage.StorageException;
/**
* Abstract data region for {@link PageMemoryStorageEngine}. Based on a {@link
PageMemory}.
*/
-abstract class AbstractPageMemoryDataRegion implements PageMemoryDataRegion,
IgniteComponent {
- protected final PageMemoryDataRegionConfiguration cfg;
+abstract class AbstractPageMemoryDataRegion<T extends PageMemory> implements
DataRegion<T>, IgniteComponent {
Review Comment:
Because it breaks the intention of this interface. IgniteComponents have
their own lifecycle and are managed by the `LifecycleManager`. Anyway, why do
you need an interface to have `start` and `stop` methods? What's wrong with
declaring them in this class directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
