ptupitsyn commented on code in PR #949:
URL: https://github.com/apache/ignite-3/pull/949#discussion_r925924490
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -191,7 +194,7 @@ private void handshake(ChannelHandlerContext ctx,
ClientMessageUnpacker unpacker
var clientVer = ProtocolVersion.unpack(unpacker);
if (!clientVer.equals(ProtocolVersion.LATEST_VER)) {
- throw new IgniteException("Unsupported version: "
+ throw new IgniteException(PROTOCOL_ERR, "Unsupported version: "
Review Comment:
Good point, added PROTOCOL_COMPATIBILITY_ERR.
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -191,7 +194,7 @@ private void handshake(ChannelHandlerContext ctx,
ClientMessageUnpacker unpacker
var clientVer = ProtocolVersion.unpack(unpacker);
if (!clientVer.equals(ProtocolVersion.LATEST_VER)) {
- throw new IgniteException("Unsupported version: "
+ throw new IgniteException(PROTOCOL_ERR, "Unsupported version: "
Review Comment:
Good point, added `PROTOCOL_COMPATIBILITY_ERR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
