ptupitsyn commented on code in PR #949:
URL: https://github.com/apache/ignite-3/pull/949#discussion_r925926701
##########
modules/client/src/main/java/org/apache/ignite/internal/client/ReliableChannel.java:
##########
@@ -296,9 +297,9 @@ private <T> void handleServiceAsync(final
CompletableFuture<T> fut,
* @return host:port_range address lines parsed as {@link
InetSocketAddress} as a key. Value is the amount of appearences of an address
* in {@code addrs} parameter.
*/
- private static Map<InetSocketAddress, Integer> parsedAddresses(String[]
addrs) throws IgniteClientException {
+ private static Map<InetSocketAddress, Integer> parsedAddresses(String[]
addrs) {
if (addrs == null || addrs.length == 0) {
- throw new IgniteClientException("Empty addresses");
+ throw new IgniteException(UNKNOWN_ERR, "Empty addresses");
Review Comment:
Added `CONFIGURATION_ERR`.
##########
modules/client/src/main/java/org/apache/ignite/internal/client/ReliableChannel.java:
##########
@@ -557,7 +559,7 @@ private ClientChannel getDefaultChannel() {
}
}
- throw new IgniteClientConnectionException("Failed to connect",
failure);
+ throw new IgniteClientConnectionException(UNKNOWN_ERR, "Failed to
connect", failure);
Review Comment:
Agree, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
