ptupitsyn commented on code in PR #949:
URL: https://github.com/apache/ignite-3/pull/949#discussion_r925930516
##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientAsyncResultSet.java:
##########
@@ -134,11 +136,11 @@ public CompletionStage<? extends AsyncResultSet>
fetchNextPage() {
requireResultSet();
if (closed) {
- return CompletableFuture.failedFuture(new
IgniteClientException("Cursor is closed."));
+ return CompletableFuture.failedFuture(new
IgniteException(UNKNOWN_ERR, "Cursor is closed."));
}
if (!hasMorePages()) {
- return CompletableFuture.failedFuture(new
IgniteClientException("No more pages."));
+ return CompletableFuture.failedFuture(new
IgniteException(UNKNOWN_ERR, "No more pages."));
Review Comment:
In most cases we should not. I've added TODOs here with a link to
[IGNITE-17135 SQL API: Exceptions are different on server and
client](https://issues.apache.org/jira/browse/IGNITE-17135).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
