denis-chudov commented on code in PR #957: URL: https://github.com/apache/ignite-3/pull/957#discussion_r937822579
########## modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricSource.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.metrics; + +/** + * Interface for all metrics source. + */ +public interface MetricSource { Review Comment: it's acceptable to create an adjective from the noun in singular form and it says nothing about the number of things described by the adjective. We agreed to leave it without 's'. ########## modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricSet.java: ########## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.metrics; + +import java.util.Collection; +import java.util.Collections; +import java.util.Iterator; +import java.util.Map; +import org.apache.ignite.internal.metrics.composite.CompositeMetric; +import org.jetbrains.annotations.Nullable; +import org.jetbrains.annotations.TestOnly; + +/** + * The Metric set that consists of set of metrics identified by a metric name. + * The metrics set is immutable. + */ +public class MetricSet implements Iterable<Metric> { Review Comment: it's acceptable to create an adjective from the noun in singular form and it says nothing about the number of things described by the adjective. We agreed to leave it without 's'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
