denis-chudov commented on code in PR #957: URL: https://github.com/apache/ignite-3/pull/957#discussion_r941206123
########## modules/metrics/src/test/java/org/apache/ignite/internal/metrics/ThreadPoolMetricTest.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.metrics; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +import java.util.concurrent.ExecutionException; +import java.util.concurrent.LinkedBlockingQueue; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; +import org.junit.jupiter.api.Test; + +/** + * Metrics for thread pool. + */ +public class ThreadPoolMetricTest { + @Test + public void test() throws ExecutionException, InterruptedException { + // Should be one per node. + MetricRegistry registry = new MetricRegistry(); + + // ------------------------------------------------------------------------ + + // System component, e.g. thread pool executor + ThreadPoolExecutor exec = new ThreadPoolExecutor(4, 4, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>()); + + // Metrics source for thread pool + ThreadPoolMetricSource src = new ThreadPoolMetricSource("example.thread_pool.ExamplePool", exec); + + // Register source after the component created. + registry.registerSource(src); + + // ------------------------------------------------------------------------ + + // Enable metrics by signal (or because configuration) + MetricSet metricSet = registry.enable(src.name()); + + LongMetric completedTaskCount = metricSet.get("CompletedTaskCount"); Review Comment: Mainly, ThreadPoolMetricSource serves as an example that is a bit less abstract than MetricEntitiesTest, and functionality itself should be checked in other tests, so it seems not to be a problem, as for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
