[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1161: IGNITE-17536 Implement BinaryTuple inlining in a hash index B+Tree

[GitBox]

tkalkirill commented on code in PR #1161:
URL: https://github.com/apache/ignite-3/pull/1161#discussion_r994310838


##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/io/HashIndexTreeIo.java:
##########
@@ -43,25 +52,27 @@
  * <p>Defines a following data layout:
  * <ul>
  *     <li>Index columns hash - int (4 bytes);</li>
- *     <li>Index columns link - long (6 bytes);</li>
+ *     <li>Inlined index columns size - short (2 bytes), no more than the 
{@link InlineUtils#MAX_BINARY_TUPLE_INLINE_SIZE}, the most
+ *     significant (sign) bit is used to determine whether there is a link to 
the index columns, if negative then no link;</li>
+ *     <li>Inlined index columns - N bytes;</li>
+ *     <li>Index columns link (optional)- 6 bytes, if the inlined index 
columns are the same size as the original index columns, no link is

Review Comment:
   fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org