tkalkirill commented on code in PR #1161:
URL: https://github.com/apache/ignite-3/pull/1161#discussion_r995420509


##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/io/HashIndexTreeIo.java:
##########
@@ -67,6 +67,39 @@ public interface HashIndexTreeIo {
             + PARTITIONLESS_LINK_SIZE_BYTES // Index column link.
             + 2 * Long.BYTES; // Row ID.
 
+    /** Index columns are not fully inlined, the index column size is {@link 
#indexColumnsInlineSize()}. */
+    short NOT_FULLY_INLINE = -1;
+
+    /** Offset of the index columns hash (4 bytes). */
+    int HASH_OFFSET = 0;
+
+    /** Offset of the index columns size (2 bytes). */
+    int SIZE_OFFSET = HASH_OFFSET + Integer.BYTES;
+
+    /** Offset of the index columns tuple (N bytes). */
+    int TUPLE_OFFSET = SIZE_OFFSET + Short.BYTES;
+
+    /**
+     * Returns offset of the index columns link (6 bytes).
+     */
+    default int linkOffset() {

Review Comment:
   I think it will be a little strange that the offset constants are not 
private, but the methods are private.
   wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to