[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1161: IGNITE-17536 Implement BinaryTuple inlining in a hash index B+Tree

[GitBox]

tkalkirill commented on code in PR #1161:
URL: https://github.com/apache/ignite-3/pull/1161#discussion_r995421069


##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/io/HashIndexTreeIo.java:
##########
@@ -225,28 +238,22 @@ default int compare(DataPageReader dataPageReader, int 
partitionId, long pageAdd
      */
     default HashIndexRow getRow(DataPageReader dataPageReader, int 
partitionId, long pageAddr, int idx)
             throws IgniteInternalCheckedException {
-        int off = offset(idx);
+        final int off = offset(idx);

Review Comment:
   So that there is less chance of shooting yourself in the foot, as I did when 
reworking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org