[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1161: IGNITE-17536 Implement BinaryTuple inlining in a hash index B+Tree

[GitBox]

tkalkirill commented on code in PR #1161:
URL: https://github.com/apache/ignite-3/pull/1161#discussion_r995423503


##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -216,9 +217,11 @@ private PageMemoryHashIndexStorage 
createOrRestoreHashIndex(IndexMeta indexMeta)
             );
 
             if (initNew) {
-                boolean replaced = indexMetaTree.putx(new 
IndexMeta(indexMeta.id(), metaPageId, inlineSize));
+                boolean replaced = indexMetaTree.putx(new 
IndexMeta(indexMeta.id(), metaPageId));
 
                 assert !replaced;
+
+                writeHashIndexInlineSize(metaPageId, inlineSize);

Review Comment:
   I'll try to move it inside the tree.



##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -931,4 +933,48 @@ public void close() {
             // No-op.
         }
     }
+
+    private int readHashIndexInlineSize(long metaPageId) throws 
IgniteInternalCheckedException {

Review Comment:
   I'll try to move it inside the tree.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org