ibessonov commented on code in PR #1226:
URL: https://github.com/apache/ignite-3/pull/1226#discussion_r1003263387
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/OutgoingSnapshotsManager.java:
##########
@@ -141,8 +201,48 @@ private CompletableFuture<Void> respond(
NetworkAddress sender,
Long correlationId
) {
- //TODO https://issues.apache.org/jira/browse/IGNITE-17262
+ //TODO https://issues.apache.org/jira/browse/IGNITE-17935
// Handle offline sender and stopped manager.
return messagingService.respond(sender, response, correlationId);
}
+
+ @Override
+ public PartitionSnapshots partitionSnapshots(PartitionKey partitionKey) {
Review Comment:
It is public and it has a lazy-init. Is there a chance of polluting memory
with empty snapshot sets? Can't we just "get"? Or it shouldn't be nullable in
your design? Who cleans it then? I sense a memory leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
