rpuch commented on code in PR #1226:
URL: https://github.com/apache/ignite-3/pull/1226#discussion_r1003294557
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/OutgoingSnapshotsManager.java:
##########
@@ -141,8 +201,48 @@ private CompletableFuture<Void> respond(
NetworkAddress sender,
Long correlationId
) {
- //TODO https://issues.apache.org/jira/browse/IGNITE-17262
+ //TODO https://issues.apache.org/jira/browse/IGNITE-17935
// Handle offline sender and stopped manager.
return messagingService.respond(sender, response, correlationId);
}
+
+ @Override
+ public PartitionSnapshots partitionSnapshots(PartitionKey partitionKey) {
Review Comment:
Yes, it should return something non-nullable so that the one who makes a
write needs to take a lock on the collection of snapshots of the partition.
I planned to clean it on partition destroy. For now, it is a handful of
objects per alive partition, doesn't seem too wasteful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
