rpuch commented on code in PR #1226:
URL: https://github.com/apache/ignite-3/pull/1226#discussion_r1003282751
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/OutgoingSnapshotsManager.java:
##########
@@ -65,41 +91,69 @@ public MessagingService messagingService() {
@Override
public void start() {
- messagingService.addMessageHandler(TableMessageGroup.class,
this::messageHandler);
+ executor = Executors.newFixedThreadPool(4, new
NamedThreadFactory("outgoing-snapshots", LOG));
Review Comment:
I just did not want to start the pool before the component is started. The
field is `volatile` because `start()` might be called from a thread different
from the thread where the object is instantiated.
`4` is a first guess. This should probably be configured. The PR is already
pretty bloated. Let's leave it as is and continue in IGNITE-17935.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
