isapego commented on code in PR #1272: URL: https://github.com/apache/ignite-3/pull/1272#discussion_r1010504485
########## modules/platforms/cpp/ignite/common/config.h: ########## @@ -51,10 +51,12 @@ #endif /** - * Macro IGNITE_SWITCH_WIN_OTHER that uses first option on Windows and second on any other OS. + * Macro IGNITE_OS_SWITCH that uses first option on Windows, second on Linux and third on MacOS. Review Comment: I'm not sure there going to be a lot of other platforms, actually. I would not remove `IGNITE_SWITCH_WIN_OTHER` macro while adding `IGNITE_OS_SWITCH` by the way, as there are a lot of places where there is the same code for Linux and macOS, so it's still very usable in most places. Anyway, even `IGNITE_OS_SWITCH` is not a big deal currently, and for the future - we will see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
