isapego commented on code in PR #1272:
URL: https://github.com/apache/ignite-3/pull/1272#discussion_r1010552241
##########
modules/platforms/cpp/tests/test-common/ignite_runner.cpp:
##########
@@ -30,8 +30,8 @@ namespace {
/**
* System shell command string.
*/
-constexpr std::string_view SYSTEM_SHELL = IGNITE_SWITCH_WIN_OTHER("cmd.exe",
"/bin/sh");
-constexpr std::string_view SYSTEM_SHELL_ARG_0 = IGNITE_SWITCH_WIN_OTHER("/c ",
"-c");
+constexpr std::string_view SYSTEM_SHELL = IGNITE_OS_SWITCH("cmd.exe",
"/bin/sh", "/bin/sh");
+constexpr std::string_view SYSTEM_SHELL_ARG_0 = IGNITE_OS_SWITCH("/c ", "-c",
"-c");
Review Comment:
Original macro `IGNITE_SWITCH_WIN_OTHER` would fit perfectly here, why
change it just to duplicate the same code for Linux and macOS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
