sashapolo commented on code in PR #1348:
URL: https://github.com/apache/ignite-3/pull/1348#discussion_r1026547909
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1890,15 +1886,15 @@ public boolean onUpdate(@NotNull WatchEvent evt) {
RaftGroupService partGrpSvc =
internalTable.partitionRaftGroupService(partId);
- IgniteBiTuple<Peer, Long> leaderWithTerm =
partGrpSvc.refreshAndGetLeaderWithTerm().join();
+ LeaderWithTerm leaderWithTerm =
partGrpSvc.refreshAndGetLeaderWithTerm().join();
// run update of raft configuration if this node is a
leader
- if
(localMember.name().equals(leaderWithTerm.get1().consistentId())) {
+ if
(localMember.name().equals(leaderWithTerm.leader().consistentId())) {
LOG.info("Current node={} is the leader of partition
raft group={}. "
+ "Initiate rebalance process for
partition={}, table={}",
localMember.address(), replicaGrpId, partId,
tbl.name());
- partGrpSvc.changePeersAsync(newNodes,
leaderWithTerm.get2()).join();
+ partGrpSvc.changePeersAsync(newNodes, List.of(),
leaderWithTerm.term()).join();
Review Comment:
that's ok for now, because nobody uses learners at the moment. I'm going to
change this in my next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
